[CP Stag] Fix User not redirected to IOU report when logging in after deeplink#49839
Conversation
|
@ikevin127 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
hey @ikevin127 , this is a follow up PR for the regression, I will take care of the checklist 😄 |
Reviewer Checklist
Screenshots/VideosAndroid: NativeScreen.Recording.2024-09-27.at.7.49.34.PM.movAndroid: mWeb ChromeScreen.Recording.2024-09-27.at.7.44.03.PM.moviOS: NativeScreen.Recording.2024-09-27.at.7.29.05.PM.moviOS: mWeb SafariScreen.Recording.2024-09-27.at.7.31.07.PM.movMacOS: Chrome / SafariScreen.Recording.2024-09-27.at.7.17.20.PM.movMacOS: DesktopScreen.Recording.2024-09-27.at.7.24.42.PM.mov |
allgandalf
left a comment
There was a problem hiding this comment.
Tests well, hopefully shouldn't cause any other regression 🤞 , please label this as [CP Staging]
…eeplinking-v2 [CP Stag] Fix User not redirected to IOU report when logging in after deeplink (cherry picked from commit 2cdd7d5) (CP triggered by AndrewGable)
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Cherry-picked to staging by https://github.com/AndrewGable in version: 9.0.40-5 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
|
🚀 Deployed to production by https://github.com/AndrewGable in version: 9.0.40-6 🚀
|
Details
Because of changes introduced in #49516, deeplinking logic was moved to
onCompletedcallback, I missed a case where the onboarding is eitherundefinedor an empty array (PHP layer return an empty array for older accounts). For these cases we early returned and bothonCompletedandonNotCompletedcallbacks weren't triggered.Fixed Issues
$ #49798
PROPOSAL: N/A
Tests
Preconditions: Account with existing IOU report, IOU report URL copied and navigate to some other report
Offline tests
N/A
QA Steps
N/A
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel so the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2024-09-27.at.15.47.53.mov
iOS: Native
Simulator.Screen.Recording.-.iPhone.taki.SE.-.2024-09-27.at.15.26.44.mp4
MacOS: Chrome / Safari
Screen.Recording.2024-09-27.at.14.26.01.mov